1use crate::core::algorithm::Driver;
5use crate::{LibsyError, Result};
6use async_trait::async_trait;
7use switchyard_protocol::{Request, Response};
8
9#[derive(Debug, Clone, PartialEq)]
11pub struct Score {
12 pub confidence: f64,
14 pub target: String,
16}
17
18pub enum Classification {
21 Scores(Vec<Score>),
23 Ambiguous(Vec<Score>),
26}
27
28impl Classification {
29 pub fn argmax(&self, ignore_ambiguous: bool) -> Result<Option<Score>> {
35 match self {
36 Classification::Scores(scores) => argmax(scores),
37 Classification::Ambiguous(scores) => {
38 if ignore_ambiguous {
39 argmax(scores)
40 } else {
41 Ok(None)
42 }
43 }
44 }
45 }
46}
47
48fn argmax(scores: &[Score]) -> Result<Option<Score>> {
52 let mut best: Option<&Score> = None;
53 for score in scores.iter() {
54 if score.confidence.is_nan() {
55 return Err(LibsyError::AlgorithmError {
56 message: format!(
57 "classifier returned NaN confidence for target {:?}",
58 score.target
59 ),
60 });
61 }
62 match best {
63 Some(cur_best) if score.confidence > cur_best.confidence => best = Some(score),
64 None => best = Some(score),
65 _ => {}
66 }
67 }
68 Ok(best.cloned())
69}
70
71#[async_trait]
73pub trait Classifier<S = ()>: Send + Sync {
74 fn routing_tier(&self, _selected_model: &str) -> Option<&'static str> {
76 None
77 }
78
79 async fn score(
90 &self,
91 state: &mut S,
92 request: &mut Request,
93 driver: Option<&Driver>,
94 ) -> Result<(Classification, Option<Response>)>;
95}
96
97#[cfg(test)]
98mod tests {
99 use super::*;
100 use switchyard_protocol::text_request;
101
102 fn score(target: &str, confidence: f64) -> Score {
104 Score {
105 target: target.to_string(),
106 confidence,
107 }
108 }
109
110 #[test]
111 fn argmax_picks_the_highest_confidence_score() -> Result<()> {
112 let scores = vec![score("weak", 0.2), score("strong", 0.9), score("mid", 0.5)];
113 let best = Classification::Scores(scores).argmax(false)?;
114 assert_eq!(best, Some(score("strong", 0.9)));
115 Ok(())
116 }
117
118 #[test]
119 fn argmax_breaks_ties_by_cascade_order() -> Result<()> {
120 let scores = vec![score("first", 0.7), score("second", 0.7)];
122 let best = Classification::Scores(scores).argmax(false)?;
123 assert_eq!(best.map(|s| s.target), Some("first".to_string()));
124 Ok(())
125 }
126
127 #[test]
128 fn argmax_on_an_empty_set_abstains() -> Result<()> {
129 assert_eq!(Classification::Scores(vec![]).argmax(false)?, None);
131 assert_eq!(Classification::Ambiguous(vec![]).argmax(true)?, None);
132 Ok(())
133 }
134
135 #[test]
136 fn argmax_errors_on_nan_confidence() {
137 let scores = vec![score("weak", 0.3), score("strong", f64::NAN)];
139 assert!(matches!(
140 Classification::Scores(scores).argmax(false),
141 Err(LibsyError::AlgorithmError { message })
142 if message == "classifier returned NaN confidence for target \"strong\""
143 ));
144 assert!(matches!(
146 Classification::Scores(vec![score("only", f64::NAN)]).argmax(false),
147 Err(LibsyError::AlgorithmError { message })
148 if message == "classifier returned NaN confidence for target \"only\""
149 ));
150 }
151
152 #[test]
153 fn ambiguous_without_ignore_makes_no_choice() -> Result<()> {
154 let scores = vec![score("strong", 0.9)];
156 assert_eq!(Classification::Ambiguous(scores).argmax(false)?, None);
157 Ok(())
158 }
159
160 #[test]
161 fn ambiguous_with_ignore_falls_back_to_argmax() -> Result<()> {
162 let scores = vec![score("weak", 0.3), score("strong", 0.8)];
163 let best = Classification::Ambiguous(scores).argmax(true)?;
164 assert_eq!(best, Some(score("strong", 0.8)));
165 Ok(())
166 }
167
168 #[test]
169 fn scores_variant_ignores_the_ambiguous_flag() -> Result<()> {
170 let scores = vec![score("a", 0.4), score("b", 0.6)];
172 let with_ignore = Classification::Scores(scores.clone()).argmax(true)?;
173 let without_ignore = Classification::Scores(scores).argmax(false)?;
174 assert_eq!(with_ignore, without_ignore);
175 assert_eq!(with_ignore, Some(score("b", 0.6)));
176 Ok(())
177 }
178
179 struct RecordingClassifier;
181
182 #[async_trait]
183 impl Classifier<bool> for RecordingClassifier {
184 async fn score(
185 &self,
186 state: &mut bool,
187 request: &mut Request,
188 _driver: Option<&Driver>,
189 ) -> Result<(Classification, Option<Response>)> {
190 *state = true;
191 let target = request.requested_model().unwrap_or("auto").to_string();
192 Ok((
193 Classification::Scores(vec![Score {
194 target,
195 confidence: 1.0,
196 }]),
197 None,
198 ))
199 }
200 }
201
202 #[tokio::test]
203 async fn classifier_reads_request_and_mutates_state() -> Result<()> {
204 let mut state = false;
205 let mut request = Request {
206 llm_request: text_request(Some("strong".to_string()), "hi"),
207 raw_request: None,
208 metadata: None,
209 };
210 let (classification, _) = RecordingClassifier
212 .score(&mut state, &mut request, None)
213 .await?;
214 assert_eq!(
215 classification.argmax(false)?.map(|s| s.target),
216 Some("strong".to_string())
217 );
218 assert!(state);
219 Ok(())
220 }
221
222 struct RewritingClassifier;
224
225 #[async_trait]
226 impl Classifier for RewritingClassifier {
227 async fn score(
228 &self,
229 _state: &mut (),
230 request: &mut Request,
231 _driver: Option<&Driver>,
232 ) -> Result<(Classification, Option<Response>)> {
233 request.llm_request.model = Some("rewritten".to_string());
234 Ok((
235 Classification::Scores(vec![Score {
236 target: "rewritten".to_string(),
237 confidence: 1.0,
238 }]),
239 None,
240 ))
241 }
242 }
243
244 #[tokio::test]
245 async fn classifier_rewrites_the_request_in_place() -> Result<()> {
246 let mut state = ();
247 let mut request = Request {
248 llm_request: text_request(Some("auto".to_string()), "hi"),
249 raw_request: None,
250 metadata: None,
251 };
252
253 RewritingClassifier
254 .score(&mut state, &mut request, None)
255 .await?;
256
257 assert_eq!(request.requested_model(), Some("rewritten"));
260 Ok(())
261 }
262}